Hi Jordan. On Mon, Mar 02, 2020 at 11:23:43AM -0700, Jordan Crouse wrote: > Convert display/msm/gmu.txt to display/msm/gmu.yaml and remove the old > text bindings. > > Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> > --- > > .../devicetree/bindings/display/msm/gmu.txt | 116 ------------------- > - > -Required properties: > -- compatible: "qcom,adreno-gmu-XYZ.W", "qcom,adreno-gmu" > - for example: "qcom,adreno-gmu-630.2", "qcom,adreno-gmu" > - Note that you need to list the less specific "qcom,adreno-gmu" > - for generic matches and the more specific identifier to identify > - the specific device. > -- reg: Physical base address and length of the GMU registers. > -- reg-names: Matching names for the register regions > - * "gmu" > - * "gmu_pdc" > - * "gmu_pdc_seg" > -- interrupts: The interrupt signals from the GMU. > -- interrupt-names: Matching names for the interrupts > - * "hfi" > - * "gmu" > -- clocks: phandles to the device clocks > -- clock-names: Matching names for the clocks > - * "gmu" > - * "cxo" > - * "axi" > - * "mnoc" The new binding - and arch/arm64/boot/dts/qcom/sdm845.dtsi agrees that "mnoc" is wrong. > -- power-domains: should be: > - <&clock_gpucc GPU_CX_GDSC> > - <&clock_gpucc GPU_GX_GDSC> > -- power-domain-names: Matching names for the power domains > -- iommus: phandle to the adreno iommu > -- operating-points-v2: phandle to the OPP operating points > - > -Optional properties: > -- sram: phandle to the On Chip Memory (OCMEM) that's present on some Snapdragon > - SoCs. See Documentation/devicetree/bindings/sram/qcom,ocmem.yaml. This property is not included in the new binding. Everything else looked fine to me. With sram added - or expalined in commit why it is dropped: Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> Sam
