Hi Heiko. On Tue, Feb 25, 2020 at 10:39:12AM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@xxxxxxxxxxxxxxxxxxxxx> > > The KD35T133 is a 3.5" 320x480 DSI display used in the RK3326-based > Odroid Go Advance handheld device. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@xxxxxxxxxxxxxxxxxxxxx> One small comment, but anyway: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > --- > .../display/panel/elida,kd35t133.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml > new file mode 100644 > index 000000000000..4bd74eaa61be > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/elida,kd35t133.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Elida KD35T133 3.5in 320x480 DSI panel > + > +maintainers: > + - Heiko Stuebner <heiko.stuebner@xxxxxxxxxxxxxxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: elida,kd35t133 > + reg: true > + backlight: true > + reset-gpios: true > + iovcc-supply: > + description: regulator that supplies the iovcc voltage > + vdd-supply: > + description: regulator that supplies the vdd voltage > + > +required: > + - compatible > + - reg > + - backlight Is backlight really required? If it is tied to for example vcc then there is nothing to express in the DT. Sam > + - iovcc-supply > + - vdd-supply > + > +additionalProperties: false > + > +examples: > + - | > + dsi@ff450000 { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "elida,kd35t133"; > + reg = <0>; > + backlight = <&backlight>; > + iovcc-supply = <&vcc_1v8>; > + vdd-supply = <&vcc3v3_lcd>; > + }; > + }; > + > +... > -- > 2.24.1
