Re: [PATCH v7 3/7] Bindings: nvmem: add bindings for JZ4780 efuse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Le ven., févr. 28, 2020 at 15:47, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> a écrit :

 Am 28.02.2020 um 15:40 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>:

 Hi Nikolaus,


Le ven., févr. 28, 2020 at 14:58, H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> a écrit :
 From: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
This patch brings support for the JZ4780 efuse. Currently it only exposes
 a read only access to the entire 8K bits efuse memory.
 Tested-by: Mathieu Malaterre <malat@xxxxxxxxxx>
Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
 Signed-off-by: Mathieu Malaterre <malat@xxxxxxxxxx>
 Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
 [converted to yaml]
 Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
 ---
.../bindings/nvmem/ingenic,jz4780-efuse.yaml | 49 +++++++++++++++++++
 1 file changed, 49 insertions(+)
create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml diff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
 new file mode 100644
 index 000000000000..ce6690c50a34
 --- /dev/null
+++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml
 @@ -0,0 +1,49 @@
 +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
 +%YAML 1.2
 +---
+$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml#
 +$schema: http://devicetree.org/meta-schemas/core.yaml#
 +
 +title: Ingenic JZ EFUSE driver bindings
 +
 +maintainers:
 +  - PrasannaKumar Muralidharan <prasannatsmkumar@xxxxxxxxx>
 +
 +allOf:
 +  - $ref: "nvmem.yaml#"
 +
 +properties:
 +  compatible:
 +    enum:
 +      - ingenic,jz4780-efuse
 +
 +  reg:
 +    maxItems: 1
 +
 +  clocks:
 +    # Handle for the ahb for the efuse.
 +    maxItems: 1
 +
 +  clock-names:
 +    items:
 +      - const: ahb2

 You still have clock-names here. You can remove it completely.

I have just removed them from required: and the examples: because
I think they are optional. Or are they forbidden?

The driver does not get its clock by name, it just takes the first one. So having 'clock-names' in the binding is just not needed.

-Paul


 +
 +required:
 +  - compatible
 +  - reg
 +  - clocks
 +
 +unevaluatedProperties: false
 +
 +examples:
 +  - |
 +    #include <dt-bindings/clock/jz4780-cgu.h>
 +
 +    efuse@134100d0 {
 +        compatible = "ingenic,jz4780-efuse";
 +        reg = <0x134100d0 0x2c>;
 +
 +        clocks = <&cgu JZ4780_CLK_AHB2>;
 +    };
 +
 +...
 --
 2.23.0

BR,
Nikolaus







[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux