On Fri, Feb 28, 2020 at 11:47:53AM +0000, Russell King - ARM Linux admin wrote: > On Wed, Feb 26, 2020 at 09:21:38AM +0000, Russell King - ARM Linux admin wrote: > > On Wed, Feb 26, 2020 at 06:46:24AM +0100, Oleksij Rempel wrote: > > > The port to phylink was done as close as possible to initial > > > functionality. > > > > > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > > > --- > > > changes v8: > > > - set the autoneg bit > > > - provide implementations for the mac_pcs_get_state and mac_an_restart > > > methods > > > - do phylink_disconnect_phy() on _stop() > > > - rename ag71xx_phy_setup() to ag71xx_phylink_setup() > > > > There will be one more change required; I'm changing the prototype for > > the mac_link_up() function, and I suggest as you don't support in-band > > AN that most of the setup for speed and duplex gets moved out of your > > mac_config() implementation to mac_link_up(). > > > > The patches have been available on netdev for just over a week now. > > The patches are now in net-next. Please respin your patch against these > changes, which basically means the code which programs the speed and > duplex in ag71xx_mac_config() needs to be moved to ag71xx_mac_link_up(). OK, Thank you! I'll update it. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
