Hi, Shawn Will you take patch #4 and #5? Thanks. Anson > Subject: Re: [PATCH V16 1/5] dt-bindings: fsl: scu: add thermal binding > > On 22/02/2020 01:08, Anson Huang wrote: > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and thermal sensors etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get temperature > > from thermal sensors, this patch adds binding doc for i.MX system > > controller thermal driver. > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx> > > I'll will take patches 1, 2 and 3 > > Thanks! > > -- Daniel > > > --- > > No change. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt | 16 > ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index e07735a8..7f42cc3 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -166,6 +166,17 @@ Required properties: > > followed by "fsl,imx-sc-key"; > > - linux,keycodes: See > > Documentation/devicetree/bindings/input/keys.txt > > > > +Thermal bindings based on SCU Message Protocol > > +------------------------------------------------------------ > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See > Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > + > > Example (imx8qxp): > > ------------- > > aliases { > > @@ -238,6 +249,11 @@ firmware { > > compatible = "fsl,imx8qxp-sc-wdt", "fsl,imx-sc-wdt"; > > timeout-sec = <60>; > > }; > > + > > + tsens: thermal-sensor { > > + compatible = "fsl,imx8qxp-sc-thermal", "fsl,imx-sc- > thermal"; > > + #thermal-sensor-cells = <1>; > > + }; > > }; > > }; > > > > > > > -- > > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > linaro.org%2F&data=02%7C01%7CAnson.Huang%40nxp.com%7Ca5fb78 > c828bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C > 0%7C0%7C637183913730069723&sdata=qKt%2BmT7yTwAmtzUkaujB%2 > BuQX0qSzaj32r3cwL0coPAw%3D&reserved=0> Linaro.org │ Open > source software for ARM SoCs > > Follow Linaro: > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > facebook.com%2Fpages%2FLinaro&data=02%7C01%7CAnson.Huang%4 > 0nxp.com%7Ca5fb78c828bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa9 > 2cd99c5c301635%7C0%7C0%7C637183913730069723&sdata=S1QNjqHq > X1njW436D5jcnZKSmdm%2BZty5sMCO03CvNts%3D&reserved=0> > Facebook | > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitte > r.com%2F%23!%2Flinaroorg&data=02%7C01%7CAnson.Huang%40nxp.c > om%7Ca5fb78c828bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa92cd99c > 5c301635%7C0%7C0%7C637183913730069723&sdata=4j%2FDXNQieTgs > XhvWWYNSTgnpbj8U0b8SKd62XeBxz8Y%3D&reserved=0> Twitter | > <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww. > linaro.org%2Flinaro- > blog%2F&data=02%7C01%7CAnson.Huang%40nxp.com%7Ca5fb78c828 > bd40f20c6a08d7bb64c1f3%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C > 0%7C637183913730069723&sdata=onbNbXAbnxwYwUTMpG5jGtsfmN% > 2BMJF8JVZV2YS0bbJw%3D&reserved=0> Blog