Hi Rob, On Thu, Feb 27, 2020 at 10:55:04AM -0600, Rob Herring wrote: > On Wed, 26 Feb 2020 15:03:46 -0800, rentao.bupt@xxxxxxxxx wrote: > > From: Tao Ren <rentao.bupt@xxxxxxxxx> > > > > Add device tree binding documentation for aspeed usb-vhub driver. > > > > Signed-off-by: Tao Ren <rentao.bupt@xxxxxxxxx> > > --- > > No change in v2/v3/v4: > > - the patch is added to the patch series since v4. > > > > .../bindings/usb/aspeed,usb-vhub.yaml | 71 +++++++++++++++++++ > > 1 file changed, 71 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dt.yaml: usb-vhub@1e6a0000: 'aspeed,vhub-downstream-ports' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/aspeed,usb-vhub.example.dt.yaml: usb-vhub@1e6a0000: 'aspeed,vhub-generic-endpoints' is a required property > > See https://patchwork.ozlabs.org/patch/1245388 > Please check and re-submit. I ran "make dt_binding_check" in my local environment and don't see the failures. The 2 properties are introduced in this patch set and I add the properties in aspeed-g4/5/6 dtsi files (patch #4, #5 and #6): am I missing something? Sorry I forgot to add you when including the dt-binding document to the series v4: will add you and all dt binding maintainers in v5 soon. Cheers, Tao
