Hi Roger, On 2/26/20 2:42 AM, Roger Quadros wrote: > Hi Suman, > > On 25/02/2020 22:46, Suman Anna wrote: >> From: Roger Quadros <rogerq@xxxxxx> >> >> The PRUSS module has a SYSCFG which is unique. The SYSCFG >> has two additional unique fields called STANDBY_INIT and >> SUB_MWAIT in addition to regular IDLE_MODE and STANDBY_MODE >> fields. Add the bindings for this new sysc type. >> >> Signed-off-by: Roger Quadros <rogerq@xxxxxx> >> Signed-off-by: Suman Anna <s-anna@xxxxxx> >> --- >> Documentation/devicetree/bindings/bus/ti-sysc.txt | 1 + >> include/dt-bindings/bus/ti-sysc.h | 4 ++++ >> 2 files changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/bus/ti-sysc.txt >> b/Documentation/devicetree/bindings/bus/ti-sysc.txt >> index 233eb8294204..c984143d08d2 100644 >> --- a/Documentation/devicetree/bindings/bus/ti-sysc.txt >> +++ b/Documentation/devicetree/bindings/bus/ti-sysc.txt >> @@ -38,6 +38,7 @@ Required standard properties: >> "ti,sysc-dra7-mcasp" >> "ti,sysc-usb-host-fs" >> "ti,sysc-dra7-mcan" >> + "ti,sysc-pruss" >> - reg shall have register areas implemented for the >> interconnect >> target module in question such as revision, sysc and syss >> diff --git a/include/dt-bindings/bus/ti-sysc.h >> b/include/dt-bindings/bus/ti-sysc.h > > Did you intentionally leave this here? It should be part of 2nd patch? No, not really, include/bindings are also considered part of bindings. This patch alone should be enough for you to add the DT nodes. regards Suman > >> index babd08a1d226..76b07826ed05 100644 >> --- a/include/dt-bindings/bus/ti-sysc.h >> +++ b/include/dt-bindings/bus/ti-sysc.h >> @@ -18,6 +18,10 @@ >> #define SYSC_DRA7_MCAN_ENAWAKEUP (1 << 4) >> +/* PRUSS sysc found on AM33xx/AM43xx/AM57xx */ >> +#define SYSC_PRUSS_SUB_MWAIT (1 << 5) >> +#define SYSC_PRUSS_STANDBY_INIT (1 << 4) >> + >> /* SYSCONFIG STANDBYMODE/MIDLEMODE/SIDLEMODE supported by hardware */ >> #define SYSC_IDLE_FORCE 0 >> #define SYSC_IDLE_NO 1 >> >