Am 2020-02-24 10:22, schrieb Z.q. Hou:
Hi Michael and Shawn,
I'll update the patch with iommu-map property.
friendly ping :)
-michael
Thanks,
Zhiqiang
-----Original Message-----
From: Michael Walle <michael@xxxxxxxx>
Sent: 2020年2月24日 16:54
To: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: Xiaowei Bao <xiaowei.bao@xxxxxxx>; Z.q. Hou
<zhiqiang.hou@xxxxxxx>; bhelgaas@xxxxxxxxxx;
devicetree@xxxxxxxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>;
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
linux-pci@xxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxxxxxxxx;
lorenzo.pieralisi@xxxxxxx; mark.rutland@xxxxxxx; M.h. Lian
<minghuan.lian@xxxxxxx>; Mingkai Hu <mingkai.hu@xxxxxxx>;
robh+dt@xxxxxxxxxx; Roy Zang <roy.zang@xxxxxxx>
Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller
DT
nodes
Hi Shawn, all,
Am 2020-02-24 09:43, schrieb Shawn Guo:
> On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote:
>> Hi Xiaowei, Hi Shawn,
>>
>> > LS1028a implements 2 PCIe 3.0 controllers.
>>
>> Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about
>> this patch anymore :(
>>
>> This doesn't work well with the IOMMU, because the iommu-map property
>> is missing. The bootloader needs the &smmu phandle to fixup the
>> entry.
>> See
>> below.
>>
>> Shawn, will you add this patch to your tree once its fixed,
>> considering it just adds the device tree node for the LS1028A?
>
> The patch/thread is a bit aged. You may want to send an updated patch
> for discussion.
So should I just pick up the patch add my two fixes and send it again?
What about
the Signed-off-by tags? Leave them? Replace them? Add mine?
-michael
