On 05/13/2014 08:06 AM, Peter De Schrijver wrote: > Add shared and cbus clocks to the Tegra124 clock implementation. > diff --git a/include/dt-bindings/clock/tegra124-car.h b/include/dt-bindings/clock/tegra124-car.h > +#define TEGRA124_CLK_C2BUS 401 > +#define TEGRA124_CLK_C3BUS 402 > +#define TEGRA124_CLK_GR3D_CBUS 403 > +#define TEGRA124_CLK_GR2D_CBUS 404 ... I worry about this a bit. IIUC, these clocks don't actually exist in HW, but are more a way of SW applying policy to the clock that do exist in HW. As such, I'm not convinced it's a good idea to expose these clock IDS to DT, since DT is supposed to represent the HW, and not be influenced by internal SW implementation details. Do any DTs actually need to used these new clock IDs? I don't think we could actually use these value in e.g. tegra124.dtsi's clocks properties, since these clocks don't exist in HW. Was it your intent to do that? If not, can't we just define these SW-internal clock IDs in the header inside the Tegra clock driver, so the values are invisible to DT? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
