Hi Boris,
Thank you for the patch.
On Fri, Jan 31, 2020 at 06:25:05PM +0100, Boris Brezillon wrote:
> And the typo (Propage -> Propagate) is still there :-(. Fixing it right
> now so I don't forget.
>
> On Tue, 28 Jan 2020 14:55:12 +0100 Boris Brezillon wrote:
> > So that the previous bridge element in the chain knows which input
> > format the panel bridge expects.
I've been told multiple times by Tomi that the commit message should be
readable by itself, not just as a continuation of the subject line. I
was annoyed in the beginning, as I had to change my habits, but I think
it's an actual improvement. You may want to pay attention to that too in
the future.
> > v10:
> > * Add changelog to the commit message
> >
> > v8 -> v9:
> > * No changes
> >
> > v7:
> > * Set atomic state hooks explicitly
> >
> > v4 -> v6:
> > * Not part of the series
> >
> > v3:
> > * Adjust things to match the new bus-format negotiation approach
> > * Use drm_atomic_helper_bridge_propagate_bus_fmt
> > * Don't implement ->atomic_check() (the core now takes care of bus
> > flags propagation)
> >
> > v2:
> > * Adjust things to match the new bus-format negotiation approach
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
With the typo fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/bridge/panel.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index f66777e24968..dcc72bd7df30 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -127,6 +127,10 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = {
> > .enable = panel_bridge_enable,
> > .disable = panel_bridge_disable,
> > .post_disable = panel_bridge_post_disable,
> > + .atomic_reset = drm_atomic_helper_bridge_reset,
> > + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state,
> > + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> > + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt,
> > };
> >
> > /**
--
Regards,
Laurent Pinchart
