Hi Rob, On Sat, Feb 22, 2020 at 12:25 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, 21 Feb 2020 11:10:00 +0900, Masahiro Yamada wrote: > > Convert the Socionext UniPhier board/SoC binding to DT schema format. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > > --- > > > > .../bindings/arm/socionext/uniphier.txt | 47 ------------- > > .../bindings/arm/socionext/uniphier.yaml | 70 +++++++++++++++++++ > > MAINTAINERS | 2 +- > > 3 files changed, 71 insertions(+), 48 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/socionext/uniphier.txt > > create mode 100644 Documentation/devicetree/bindings/arm/socionext/uniphier.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > Error: Documentation/devicetree/bindings/arm/socionext/uniphier.example.dts:18.9-10 syntax error > FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:300: recipe for target 'Documentation/devicetree/bindings/arm/socionext/uniphier.example.dt.yaml' failed > make[1]: *** [Documentation/devicetree/bindings/arm/socionext/uniphier.example.dt.yaml] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1241745 > Please check and re-submit. I checked 'make dtbs_check', but did not test 'make dt_binding_check'. I remember that 'make dtbs_check' no longer check example.dts after 93512dad334deb444619505f1fbb761156f7471b Anyway, the example is fold into the plugin node, so I cannot avoid the schema error about $nodename. /home/masahiro/workspace/linux-unph/Documentation/devicetree/bindings/arm/socionext/uniphier.example.dt.yaml: example-0: $nodename:0: '/' was expected I will remove this example. -- Best Regards Masahiro Yamada
