Hi Rob, Sorry to introduce this mistake. I have sent a patch to fix it. Thanks for your time. On 2020/2/20 21:27, Rob Herring wrote: > On Wed, Jan 15, 2020 at 5:30 AM Jianxin Pan <jianxin.pan@xxxxxxxxxxx> wrote: >> >> Add the bindings for the Amlogic Secure power domains, controlling the >> secure power domains. >> >> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the >> power domain registers are in secure world. >> >> Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx> >> --- >> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 40 ++++++++++++++++++++++ >> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++ >> 2 files changed, 72 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> create mode 100644 include/dt-bindings/power/meson-a1-power.h >> >> diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> new file mode 100644 >> index 00000000..af32209 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >> @@ -0,0 +1,40 @@ >> +# SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +# Copyright (c) 2019 Amlogic, Inc >> +# Author: Jianxin Pan <jianxin.pan@xxxxxxxxxxx> >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-pwrc.yaml#"; >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; >> + >> +title: Amlogic Meson Secure Power Domains >> + >> +maintainers: >> + - Jianxin Pan <jianxin.pan@xxxxxxxxxxx> >> + >> +description: |+ >> + Secure Power Domains used in Meson A1/C1 SoCs, and should be the child node >> + of secure-monitor. >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,meson-a1-pwrc >> + >> + "#power-domain-cells": >> + const: 1 >> + >> +required: >> + - compatible >> + - "#power-domain-cells" >> + >> +examples: >> + - | >> + secure-monitor { >> + compatible = "amlogic,meson-gxbb-sm"; >> + >> + pwrc: power-controller { >> + compatible = "amlogic,meson-a1-pwrc"; >> + #power-domain-cells = <1>; >> + }; >> + } > > Missing ';': > > Error: Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.example.dts:27.5-6 > syntax error > FATAL ERROR: Unable to parse input tree > > Please fix this as linux-next is now failing dt_binding_check. > > Rob > > . >
