Hi Ben, On Mon, Apr 14, 2014 at 11:35 PM, Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> wrote: > --- a/arch/arm/boot/dts/r8a7790.dtsi > +++ b/arch/arm/boot/dts/r8a7790.dtsi > @@ -671,16 +671,17 @@ > compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks"; > reg = <0 0xe6150138 0 4>, <0 0xe6150040 0 4>; > clocks = <&mp_clk>, <&mp_clk>, <&mp_clk>, <&mp_clk>, <&mp_clk>, > - <&mp_clk>, <&mp_clk>, <&mp_clk>, <&mp_clk>; > + <&mp_clk>, <&mp_clk>, <&mp_clk>, <&mp_clk>, <&hp_clk>, <&hp_clk>; According to the docs, the parent clock of SYS-DMAC[01] is the ZS clock (at 260 MHz), not the HP clock (at 130 MHz). > #clock-cells = <1>; > renesas,clock-indices = < > R8A7790_CLK_SCIFA2 R8A7790_CLK_SCIFA1 R8A7790_CLK_SCIFA0 > R8A7790_CLK_MSIOF2 R8A7790_CLK_SCIFB0 R8A7790_CLK_SCIFB1 > R8A7790_CLK_MSIOF1 R8A7790_CLK_MSIOF3 R8A7790_CLK_SCIFB2 > + R8A7790_CLK_SYS_DMAC0 R8A7790_CLK_SYS_DMAC1 I know order doesn't really matter, but all other members are sorted by value, so R8A7790_CLK_SYS_DMAC1 should come before R8A7790_CLK_SYS_DMAC0. > >; > clock-output-names = > "scifa2", "scifa1", "scifa0", "msiof2", "scifb0", > - "scifb1", "msiof1", "msiof3", "scifb2"; > + "scifb1", "msiof1", "msiof3", "scifb2", "dmac0", "dmac1"; "sys-dmac0", "sys-dmac1" (and order changes, cfr. my comment above), to match the documentation? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html