On 2/20/20 9:21 AM, Enric Balletbo i Serra wrote: > From: Matthias Brugger <mbrugger@xxxxxxxx> > > The mmsys memory space is shared between the drm and the > clk driver. Use regmap to access it. > > Signed-off-by: Matthias Brugger <mbrugger@xxxxxxxx> > Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > --- > > Changes in v8: None > Changes in v7: > - Add R-by from CK > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 50 +++++++++++-------------- > drivers/gpu/drm/mediatek/mtk_drm_ddp.h | 4 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 13 ++----- > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 2 +- > 5 files changed, 30 insertions(+), 43 deletions(-) Hi. Just a quick question: Do you need to select REGMAP or one of its derivatives to make sure that the proper interfaces are available for this driver? thanks. -- ~Randy