On 2/19/20 6:37 PM, Ezequiel Garcia wrote: > Hello, > > This is v5 of Boris' rkvdec driver. > > This version corrects wrong copyright notices and then adds > a TODO file for the staging driver. The only reason to keep the > driver in staging are the staging uAPI controls. I got some sparse warnings for this series, should be trivial to fix: sparse: WARNINGS drivers/media/v4l2-core/v4l2-h264.c:214: warning: Function parameter or member 'reflist' not described in 'v4l2_h264_build_p_ref_list' drivers/media/v4l2-core/v4l2-h264.c:214: warning: Excess function parameter 'p_reflist' description in 'v4l2_h264_build_p_ref_list' SPARSE:drivers/staging/media/rkvdec/rkvdec.c drivers/staging/media/rkvdec/rkvdec.c:561:22: warning: symbol 'rkvdec_queue_ops' was not declared. Should it be static? Also, checkpatch.pl --strict complains about empty trailing lines in two files. Together with the missing MAINTAINERS it is probably best if you post a v6. Regards, Hans > > Thanks, > Ezequiel > > Boris Brezillon (5): > media: v4l2-core: Add helpers to build the H264 P/B0/B1 reflists > media: hantro: h264: Use the generic H264 reflist builder > media: dt-bindings: rockchip: Document RK3399 Video Decoder bindings > media: rkvdec: Add the rkvdec driver > arm64: dts: rockchip: rk3399: Define the rockchip Video Decoder node > > Jonas Karlman (1): > media: uapi: h264: Add DPB entry field reference flags > > .../bindings/media/rockchip,vdec.yaml | 71 + > .../media/uapi/v4l/ext-ctrls-codec.rst | 16 + > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- > drivers/media/v4l2-core/Kconfig | 4 + > drivers/media/v4l2-core/Makefile | 1 + > drivers/media/v4l2-core/v4l2-h264.c | 258 ++++ > drivers/staging/media/Kconfig | 2 + > drivers/staging/media/Makefile | 1 + > drivers/staging/media/hantro/Kconfig | 1 + > drivers/staging/media/hantro/hantro_h264.c | 237 +--- > drivers/staging/media/rkvdec/Kconfig | 15 + > drivers/staging/media/rkvdec/Makefile | 3 + > drivers/staging/media/rkvdec/TODO | 11 + > drivers/staging/media/rkvdec/rkvdec-h264.c | 1154 +++++++++++++++++ > drivers/staging/media/rkvdec/rkvdec-regs.h | 223 ++++ > drivers/staging/media/rkvdec/rkvdec.c | 1134 ++++++++++++++++ > drivers/staging/media/rkvdec/rkvdec.h | 123 ++ > include/media/h264-ctrls.h | 2 + > include/media/v4l2-h264.h | 86 ++ > 19 files changed, 3126 insertions(+), 230 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > create mode 100644 drivers/media/v4l2-core/v4l2-h264.c > create mode 100644 drivers/staging/media/rkvdec/Kconfig > create mode 100644 drivers/staging/media/rkvdec/Makefile > create mode 100644 drivers/staging/media/rkvdec/TODO > create mode 100644 drivers/staging/media/rkvdec/rkvdec-h264.c > create mode 100644 drivers/staging/media/rkvdec/rkvdec-regs.h > create mode 100644 drivers/staging/media/rkvdec/rkvdec.c > create mode 100644 drivers/staging/media/rkvdec/rkvdec.h > create mode 100644 include/media/v4l2-h264.h >
