On Wed 19 Feb 2020 at 15:55, Mark Brown <broonie@xxxxxxxxxx> wrote: >> + /* Channel Src */ >> + SOC_ENUM("Right DAC Source", dacr_in_enum), >> + SOC_ENUM("Left DAC Source", dacl_in_enum), > > Ideally these would be moved into DAPM (using an AIF_IN widget for the > DAI). I can (I initially did) but I don't think it is worth it. I would split Playback into 2 AIF for Left and Right, then add a mux to select one them if front of both DAC. It will had 4 widgets and 6 routes but it won't allow turn anything on or off. There is no PM improvement. Do you still want me to change this ?