Re: [PATCH/RFC] ARM: shmobile: armadillo-reference dts: Add matching LED labels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, May 08, 2014 at 02:06:40PM +0200, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Should the node names be changed from "led[1-4]" to "led[3-6]", too?

Yes, I think so. At the very least that would seem to be
the way it has been done for newer renesas SoCs.

> 
>  .../boot/dts/r8a7740-armadillo800eva-reference.dts |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> index 486007d7ffe4..8c7255438292 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
> @@ -106,15 +106,19 @@
>  		compatible = "gpio-leds";
>  		led1 {
>  			gpios = <&pfc 102 GPIO_ACTIVE_HIGH>;
> +			label = "LED3";
>  		};
>  		led2 {
>  			gpios = <&pfc 111 GPIO_ACTIVE_HIGH>;
> +			label = "LED4";
>  		};
>  		led3 {
>  			gpios = <&pfc 110 GPIO_ACTIVE_HIGH>;
> +			label = "LED5";
>  		};
>  		led4 {
>  			gpios = <&pfc 177 GPIO_ACTIVE_HIGH>;
> +			label = "LED6";
>  		};
>  	};
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux