On Tue, 2020-02-18 at 14:24 -0600, Rob Herring wrote: > On Tue, 18 Feb 2020 12:46:54 +1300, Chris Packham wrote: > > > > From: Logan Shaw <logan.shaw@xxxxxxxxxxxxxxxxxxx> > > > > Add documentation for the bypass-attenuator-in[0-4] property. > > > > Signed-off-by: Logan Shaw <logan.shaw@xxxxxxxxxxxxxxxxxxx> > > Signed-off-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/hwmon/adt7475.yaml | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/adt7475.yaml: patternProperties:^bypass-attenuator-in[0-4]$:maximum: False schema does not allow 1 > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/adt7475.yaml: patternProperties:^bypass-attenuator-in[0-4]$:minimum: False schema does not allow 0 > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/hwmon/adt7475.example.dts' failed > make[1]: *** [Documentation/devicetree/bindings/hwmon/adt7475.example.dts] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > I still must be doing something wrong. I did run make mrproper make ARCH=arm defconfig make ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/hwmon/adt7475.yaml which passes without error. When I run make mrproper make ARCH=arm defconfig make ARCH=arm dt_binding_check I get errors in unrelated files e.g. /home/chrisp/src/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-apb1-clk.yaml: Additional properties are not allowed ('deprecated' was unexpected) Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-apb1-clk.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-apb1-clk.example.dts] Error 1 Makefile:1262: recipe for target 'dt_binding_check' failed My local branch is based on commit 0a679e13ea30 ("Merge branch 'for- 5.6-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup") do I need to be running against something else? > See https://patchwork.ozlabs.org/patch/1239694 > Please check and re-submit.