On Fri, May 9, 2014 at 3:52 PM, Borislav Petkov <bp@xxxxxxxxx> wrote: > On Fri, May 09, 2014 at 03:31:53PM -0500, Thor Thayer wrote: >> Yes, good point. Our hardware can't recover from Double Bit Errors so >> I'll go back to the panic() in that path. I like the flexibility of >> the command line parameter though... > > Like to panic by default when the machine is booted normally but to be > able to turn off the panicking with a module parameter? > > If so, then you could probably implement a trivial setter called > > edac_mc_set_panic_on_ue() in a separate patch. > > Then, you call it at the end of altr_sdram_probe(). > > If you want to turn it off again, you do > > echo "0" > /sys/module/edac_core/parameters/edac_mc_panic_on_ue > > Something like that... > > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- Hi Boris. Yes. this would be a nice solution. I'll use the panic for now in my next revision of the patch - we know a DBE is bad news. Thanks! -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
