Re: [PATCH v2 1/3] dt-bindings: Input: da9062 - add key-opmode documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On 20-01-21 21:57, Dmitry Torokhov wrote:
> On Wed, Nov 27, 2019 at 02:23:02PM +0100, Marco Felsch wrote:
> > The onkey behaviour can be changed by programming the NONKEY_PIN
> > bitfield. Since the driver supports the reconfiguration we need to add
> > the documentation here.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > ---
> > v2:
> > - add da9061/3 references
> > - adapt binding description to be more general
> > 
> >  .../devicetree/bindings/input/da9062-onkey.txt         | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> > index 5f9fbc68e58a..0005b2bdcdd7 100644
> > --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> > +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> > @@ -19,6 +19,16 @@ Optional properties:
> >      entry exists the OnKey driver will remove support for the KEY_POWER key
> >      press when triggered using a long press of the OnKey.
> >  
> > +- dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the
> > +    otp values. 
> 
> Did you mean to say "nONKEY behavior is normally specified in OTP
> settings; this property allows modifying it".
> 
> Rob, do you have any comments?

gentle ping.

> > See nONKEY_PIN register description for more information.
> > +    Valid value range: 0x0..0x3
> > +
> > +References:
> > +
> > +[1] https://www.dialog-semiconductor.com/sites/default/files/da9061_datasheet_3v6.pdf
> > +[2] https://www.dialog-semiconductor.com/sites/default/files/da9062_datasheet_3v6.pdf
> > +[3] https://www.dialog-semiconductor.com/sites/default/files/da9063_datasheet_2v2.pdf
> > +
> >  Example: DA9063
> >  
> >  	pmic0: da9063@58 {
> > -- 
> > 2.20.1
> > 
> 
> -- 
> Dmitry
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux