Hi Shawn,
Am Donnerstag, 13. Februar 2020, 07:08:06 CET schrieb Shawn Lin:
> This IP could supports USB3.0 and PCIe.
>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
>
> ---
>
> Changes in v2:
> - fix yaml format
>
> .../bindings/phy/rockchip,inno-combophy.yaml | 80 ++++++++++++++++++++++
can we make this rockchip,inno-usb3pciephy or something similar please?
Same for the driver name.
-combophy is completely non-descriptive and looking at the Rockchip
vendor-tree we already have:
- phy-rockchip-inno-combphy.c (this one)
- phy-rockchip-inno-mipi-dphy.c (rk1808 dsi, but should actually fit into combo)
- phy-rockchip-inno-video-combo-phy.c (dsi/lvds/ttl)
- phy-rockchip-inno-video-phy.c (rk3288-lvds)
All of them have quite none-descriptive names
The inno-video-combo-phy already got a somewhat nicer name in
mainline (dsidphy), so I think it would be cool to also do this here
(and for the driver of course).
> + reset-names:
> + items:
> + - const: otg-rst
> + - const: combphy-por
> + - const: combphy-apb
> + - const: combphy-pipe
reset-names are local to the node, so there is no need
for combophy prefixes, so these should probably be:
- const: otg-rst
- const: por
- const: apb
- const: pipe
> +
> + rockchip,combphygrf:
> + enum:
> + - rockchip,combphygrf
nicer name here? :-)
Thanks
Heiko
