Hi, Bibby: On Fri, 2020-02-14 at 12:35 +0800, Bibby Hsieh wrote: > Mediatek CMDQ driver have a mechanism to do TXDONE_BY_ACK, > so we should set knows_txdone. > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > Fixes:576f1b4bc802 ("soc: mediatek: Add Mediatek CMDQ helper") > > Signed-off-by: Bibby Hsieh <bibby.hsieh@xxxxxxxxxxxx> > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 9add0fd5fa6c..2ca1a759a347 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -80,6 +80,7 @@ struct cmdq_client *cmdq_mbox_create(struct device *dev, int index, u32 timeout) > client->pkt_cnt = 0; > client->client.dev = dev; > client->client.tx_block = false; > + client->client.knows_txdone = true; > client->chan = mbox_request_channel(&client->client, index); > > if (IS_ERR(client->chan)) {