On 2020/2/11 20:16, Jerome Brunet wrote:
>
> On Tue 11 Feb 2020 at 12:10, Hanjie Lin <hanjie.lin@xxxxxxxxxxx> wrote:
>
>> Add the Amlogic A1 Family USB2 PHY Bindings
>>
>> It supports Host mode only.
>>
>> Signed-off-by: Yue Wang <yue.wang@xxxxxxxxxxx>
>> Signed-off-by: Hanjie Lin <hanjie.lin@xxxxxxxxxxx>
>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>> ---
>> .../bindings/phy/amlogic,meson-g12a-usb2-phy.yaml | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml
>> index 57d8603..3b7e763 100644
>> --- a/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-g12a-usb2-phy.yaml
>> @@ -14,6 +14,7 @@ properties:
>> compatible:
>> enum:
>> - amlogic,meson-g12a-usb2-phy
>> + - amlogic,meson-a1-usb2-phy
>>
>> reg:
>> maxItems: 1
>> @@ -49,6 +50,20 @@ required:
>> - reset-names
>> - "#phy-cells"
>>
>> +allOf:
>
> Is 'allOf' really needed when there is only one if clause ?
>
Hi jerome:
Yes, this 'allOf' is not necessary here.
I will remove it.
Thanks,
Hanjie
>> + - if:
>> + properties:
>> + compatible:
>> + enum:
>> + - amlogic,meson-a1-usb-ctrl
>> +
>> + then:
>> + properties:
>> + power-domains:
>> + maxItems: 1
>> + required:
>> + - power-domains
>> +
>> examples:
>> - |
>> phy@36000 {
>
> .
>
