Hi Amit,
On Thu, Feb 06, 2020 at 07:43:59PM +0530, Amit Kucheria wrote:
> Hi Vasily,
>
> For this entire series, the DTS files don't contain any trip points.
> Did I miss some other series?
>
> At a minimum, you should add some "hot" or "critical" trip points
> since then don't require a cooling-map with throttling actions. If you
> have "passive" trip points, then you need to provide cooling-maps.
>
> Since this series has been merged, could you please follow up with a
> fixup series to add the trip points?
I don't think lack of trip points causes runtime issues. Or does it? I planned
to send update with some trip points and cooling maps for 5.7 merge window.
Is this acceptable?
If not, I can send a patch that adds:
+ trips {
+ cpu-very-hot {
+ temperature = <100000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
and
+ trips {
+ gpu-very-hot {
+ temperature = <100000>;
+ hysteresis = <0>;
+ type = "critical";
+ };
+ };
everywhere where appropriate. Though that will make rebase of out of
tree patches that already have a more complicated setup to be sent for the next
merge window a bit tedious.
thank you,
Ondrej
> Regards,
> Amit
> p.s. We should catch all this automatically, I'll send out yaml
> bindings for the thermal framework soon that should catch this stuff.
>
> On Thu, Dec 19, 2019 at 10:58 PM Vasily Khoruzhick <anarsoul@xxxxxxxxx> wrote:
> >
> > This patchset adds driver for thermal sensor in A64, A83T, H3, H5,
> > H6 and R40 SoCs.
> >
> > v8:
> > - [vasily] Address more Maxime's comments for dt-schema
> > - [vasily] Add myself to MAINTAINERS for the driver and schema
> > - [vasily] Round calibration data size to word boundary for H6 and A64
> > - [vasily] Change offset for A64 since it reports too low temp otherwise.
> > Likely conversion formula in user manual is not correct.
> >
> > v7:
> > - [vasily] Address Maxime's comments for dt-schema
> > - [vasily] Move common part of H3 and H5 dts into sunxi-h3-h5.dtsi
> > - [vasily] Add Maxime's a-b to the driver patch
> >
> > v6:
> > - [ondrej, vasily] Squash all driver related changes into a
> > single patch
> > - [ondrej] Rename calib -> calibration
> > - [ondrej] Fix thermal zone registration check
> > - [ondrej] Lower rate of sensor data interrupts to 4/sec/sensor
> > - [ondrej] Rework scale/offset values, H6 calibration
> > - [ondrej] Explicitly set mod clock to 24 MHz
> > - [ondrej] Set undocumented bits in CTRL0 for H6
> > - [ondrej] Add support for A83T
> > - [ondrej] Add dts changes for A83T, H3, H5, H6
> > - [vasily] Add dts changes for A64
> > - [vasily] Address Maxime's comments for YAML scheme
> > - [vasily] Make .calc_temp callback mandatory
> > - [vasily] Set .max_register in regmap config, so regs can be
> > inspected using debugfs
> >
> > Ondrej Jirman (4):
> > ARM: dts: sun8i-a83t: Add thermal sensor and thermal zones
> > ARM: dts: sun8i-h3: Add thermal sensor and thermal zones
> > arm64: dts: allwinner: h5: Add thermal sensor and thermal zones
> > arm64: dts: allwinner: h6: Add thermal sensor and thermal zones
> >
> > Vasily Khoruzhick (1):
> > arm64: dts: allwinner: a64: Add thermal sensors and thermal zones
> >
> > Yangtao Li (2):
> > thermal: sun8i: add thermal driver for H6/H5/H3/A64/A83T/R40
> > dt-bindings: thermal: add YAML schema for sun8i-thermal driver
> > bindings
> >
> > .../thermal/allwinner,sun8i-a83t-ths.yaml | 160 +++++
> > MAINTAINERS | 8 +
> > arch/arm/boot/dts/sun8i-a83t.dtsi | 36 +
> > arch/arm/boot/dts/sun8i-h3.dtsi | 20 +
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 6 +
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 42 ++
> > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 26 +
> > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 +
> > drivers/thermal/Kconfig | 14 +
> > drivers/thermal/Makefile | 1 +
> > drivers/thermal/sun8i_thermal.c | 639 ++++++++++++++++++
> > 11 files changed, 985 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml
> > create mode 100644 drivers/thermal/sun8i_thermal.c
> >
> > --
> > 2.24.1
> >
