Thanks for the reviews, I will send v4 soon, sorry for the late reply. On Tue, Jan 28, 2020 at 12:25 AM Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> wrote: > > Hi Rob, > > On 27/1/20 17:12, Rob Herring wrote: > > On Mon, Jan 27, 2020 at 04:57:13PM +0100, Enric Balletbo i Serra wrote: > >> Hi Ikjoon, > >> > >> On 21/1/20 8:47, Ikjoon Jang wrote: > >>> Convert the ChromeOS EC bindings to json-schema. > >>> > >>> Signed-off-by: Ikjoon Jang <ikjn@xxxxxxxxxxxx> > >>> --- > >>> v3: node name changed in rpmsg example > >>> v2: cleanup description, fix typos, remove LPC, add add RPMSG example > >>> --- > >>> .../devicetree/bindings/mfd/cros-ec.txt | 76 ------------ > >>> .../devicetree/bindings/mfd/cros-ec.yaml | 111 ++++++++++++++++++ > >>> 2 files changed, 111 insertions(+), 76 deletions(-) > >>> delete mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.txt > >>> create mode 100644 Documentation/devicetree/bindings/mfd/cros-ec.yaml > >>> > >> > >> Still in mfd directory, this is not a MFD driver, please move to chrome/cros-ec.yaml > > > > Please don't. Looks to me like the chrome EC has multiple functions and > > is a device. > > > > This binding is part of the Chrome EC core and we explicitly moved all this out > from mfd subsytem in the past because wasn't really fit as mfd driver. > > We still have one device driver (cros_ec_dev) in mfd, this is the one that > instantiates all the subdevices but the above binding is not related to this > one. All the core/bus part is in platform/chrome, looks to me more coherent have > the binding accordingly. > > Anyway I'll let you the final decision, nothing that worries me too much. > > Thanks, > Enric > > > Bindings directories are often 1:1 with kernel driver directories, but > > not always. Converting the format at this time. I will keep the same directory in v4. It seems that cros_ec_dev device driver should be changed before moving. > > > > Rob > >
