Quoting Matthias Kaehlcke (2020-01-29 12:38:19) > On Wed, Jan 29, 2020 at 07:21:55PM +0530, Sandeep Maheswaram wrote: > > Add support for overriding QUSB2 V2 phy tuning parameters > > in device tree bindings. > > > > Signed-off-by: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > .../devicetree/bindings/phy/qcom,qusb2-phy.yaml | 33 ++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > index 43082c8..dfef356 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml > > @@ -80,6 +80,28 @@ properties: > > maximum: 63 > > default: 0 > > > > + qcom,bias-ctrl-value: > > + description: > > + It is a 6 bit value that specifies bias-ctrl-value. It is a PHY > > + tuning parameter that may vary for different boards of same SOC. > > + This property is applicable to only QUSB2 v2 PHY. > > As commented on 'dt-bindings: phy: qcom,qusb2: Convert QUSB2 phy bindings > to yaml' a possible improvement could be to restrict these properties to > the QUSB2 v2 PHY through the schema. Can this be done? It's nice to keep constraints type, otherwise the yaml binding is not as useful.
