On Fri, 31 Jan 2020 18:12:48 +0100 Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > Hi Boris. > > On Tue, Jan 28, 2020 at 02:55:11PM +0100, Boris Brezillon wrote: > > Add the bus-width property to describe the input bus format. > > > > v10: > > * Add changelog to the commit message > > * Add Rob's R-b > > > > v8 -> v9: > > * No changes > > > > v7: > > * Rebase on top of lvds-codec changes > > * Drop the data-mapping property > > > > v4 -> v6: > > * Not part of the series > > > > v3: > > * New patch > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > .../devicetree/bindings/display/bridge/lvds-codec.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > index 8f373029f5d2..7c4e42f4de61 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > > @@ -55,6 +55,14 @@ properties: > > description: | > > For LVDS encoders, port 0 is the parallel input > > For LVDS decoders, port 0 is the LVDS input > > + properties: > > + bus-width: > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + - enum: [18, 24] > > + - default: 24 > > + description: > > + Number of data lines used to transmit the RGB data. > > Would this be a candidate for a bridge-common.yaml? > So we share the same definition across all bridges using it. Could be, though the default and accepted values is likely to be overloaded on a per-bridge basis. Anyway, looks like bridge-common.yaml doesn't exists yet, so maybe we should merge this change and move the field definition when another bridge starts using this property.