On Thu, Jan 30, 2020 at 3:12 PM Douglas Anderson <dianders@xxxxxxxxxxxx> wrote:
>
> The qcom,dispcc bindings had a few problems with them:
>
> 1. They didn't specify all the clocks that dispcc is a client of.
> Specifically on sc7180 there are two clocks from the DSI PHY and
> two from the DP PHY. On sdm845 there are actually two DSI PHYs
> (each of which has two clocks) and an extra clock from the gcc.
> These all need to be specified.
>
> 2. The sdm845.dtsi has existed for quite some time without specifying
> the clocks. The Linux driver was relying on global names to match
> things up. While we should transition things, it should be noted
> in the bindings.
>
> 3. The names used the bindings for "xo" and "gpll0" didn't match the
> names that QC used for these clocks internally and this was causing
> confusion / difficulty with their code generation tools. Switched
> to the internal names to simplify everyone's lives. It's not quite
> as clean in a purist sense but it should avoid headaches. This
> officially changes the binding, but that seems OK in this case.
>
> Also note that I updated the example.
>
> Fixes: 5d28e44ba630 ("dt-bindings: clock: Add YAML schemas for the QCOM DISPCC clock bindings")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - Added include file to description.
> - Discovered / added new gcc input clock on sdm845.
> - Split sc7180 and sdm845 into two files.
> - Switched names to internal QC names rather than logical ones.
> - Updated commit description.
>
> Changes in v2:
> - Patch ("dt-bindings: clock: Fix qcom,dispcc...") new for v2.
>
> .../bindings/clock/qcom,dispcc.yaml | 67 -------------
> .../bindings/clock/qcom,sc7180-dispcc.yaml | 84 ++++++++++++++++
> .../bindings/clock/qcom,sdm845-dispcc.yaml | 99 +++++++++++++++++++
> 3 files changed, 183 insertions(+), 67 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,dispcc.yaml
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sc7180-dispcc.yaml
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,sdm845-dispcc.yaml
Other than the same $id problem,
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
