On Thu, 30 Jan 2020 21:35:54 +0100, michael.srba@xxxxxxxxx wrote: > From: Michael Srba <Michael.Srba@xxxxxxxxx> > > This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes > use of their S6E88A0 controller. > > Signed-off-by: Michael Srba <Michael.Srba@xxxxxxxxx> > --- > Hi, > I recall now that tabs cause a syntax error in yaml, should be easy to check > in checkpatch.pl? > I hope there are no more embarassing oversights left. > > Changes in v2: use yaml format for the binding > Changes in v3: fix oversights too embarassing to admit here > --- > .../panel/samsung,s6e88a0-ams452ef01.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml: $id: 'http://devicetree.org/schemas/display/panel/samsung,s6e88a0-ams452ef01#' does not match 'http://devicetree.org/schemas/.*\\.yaml#' Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.example.dts' failed make[1]: *** [Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.example.dts] Error 1 Makefile:1263: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1231597 Please check and re-submit.