On Thu, Jan 30, 2020 at 2:45 AM Benjamin Gaignard
<benjamin.gaignard@xxxxxx> wrote:
>
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> To complement panel-simple.yaml, create panel-simple-dsi.yaml.
> panel-simple-dsi-yaml are for all simple DSP panels with a single
> power-supply and optional backlight / enable GPIO / reset GPIO.
>
> Migrate panasonic,vvx10f034n00, orisetech,otm8009a and raydium,rm68200 over to the new file.
>
> The objectives with one file for all the simple DSI panels are:
> - Make it simpler to add bindings for simple DSI panels
> - Keep the number of bindings file lower
> - Keep the binding documentation for simple DSI panels more consistent
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@xxxxxx>
> Cc: Thierry Reding <thierry.reding@xxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Yannick Fertre <yannick.fertre@xxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> ---
> version 3:
> - add orisetech,otm8009a and raydium,rm68200 compatibles
> - add reset-gpios optional property
> - fix indentation on compatible enumeration
> => Rob had reviewed the second version but, given the changes in version 3
> I haven't added here.
> .../bindings/display/panel/orisetech,otm8009a.txt | 23 -------
> .../display/panel/panasonic,vvx10f034n00.txt | 20 ------
> .../bindings/display/panel/panel-simple-dsi.yaml | 74 ++++++++++++++++++++++
> .../bindings/display/panel/raydium,rm68200.txt | 25 --------
> 4 files changed, 74 insertions(+), 68 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> delete mode 100644 Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> create mode 100644 Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm68200.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt b/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> deleted file mode 100644
> index 203b03eefb68..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -Orise Tech OTM8009A 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode)
> -
> -The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using
> -a MIPI-DSI video interface. Its backlight is managed through the DSI link.
> -
> -Required properties:
> - - compatible: "orisetech,otm8009a"
> - - reg: the virtual channel number of a DSI peripheral
> -
> -Optional properties:
> - - reset-gpios: a GPIO spec for the reset pin (active low).
> - - power-supply: phandle of the regulator that provides the supply voltage.
> -
> -Example:
> -&dsi {
> - ...
> - panel@0 {
> - compatible = "orisetech,otm8009a";
> - reg = <0>;
> - reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>;
> - power-supply = <&v1v8>;
> - };
> -};
> diff --git a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt b/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> deleted file mode 100644
> index 37dedf6a6702..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/panasonic,vvx10f034n00.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Panasonic 10" WUXGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "panasonic,vvx10f034n00"
> -- reg: DSI virtual channel of the peripheral
> -- power-supply: phandle of the regulator that provides the supply voltage
> -
> -Optional properties:
> -- backlight: phandle of the backlight device attached to the panel
> -
> -Example:
> -
> - mdss_dsi@fd922800 {
> - panel@0 {
> - compatible = "panasonic,vvx10f034n00";
> - reg = <0>;
> - power-supply = <&vreg_vsp>;
> - backlight = <&lp8566_wled>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> new file mode 100644
> index 000000000000..1168b8186490
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/panel-simple-dsi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Simple DSI panels with a single power-supply
> +
> +maintainers:
> + - Thierry Reding <thierry.reding@xxxxxxxxx>
> + - Sam Ravnborg <sam@xxxxxxxxxxxx>
> +
> +description: |
> + This binding file is a collection of the DSI panels that
> + requires only a single power-supply.
> + There are optionally a backlight and an enable GPIO.
> + The panel may use an OF graph binding for the association to the display,
> + or it may be a direct child node of the display.
> +
> + If the panel is more advanced a dedicated binding file is required.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> +
> + compatible:
> + enum:
> + # compatible must be listed in alphabetical order, ordered by compatible.
> + # The description in the comment is mandatory for each compatible.
> +
> + # Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD
> + - orisetech,otm8009a
> + # Panasonic 10" WUXGA TFT LCD panel
> + - panasonic,vvx10f034n00
> + # Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD
> + - raydium,rm68200
> +
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
> + reset-gpios:
> + maxItems : 1
Can we keep whether to add 'reset-gpios' a separate discussion. If we
do add it, then it should go in panel-common.yaml and
panel-simple.yaml.
Rob
