On Wed, 2020-01-29 at 11:27 -0600, Rob Herring wrote: > On Tue, Jan 28, 2020 at 10:30 PM Logan Shaw > <Logan.Shaw@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On Mon, 2020-01-27 at 09:48 -0600, Rob Herring wrote: > > > On Mon, Jan 27, 2020 at 11:10:14AM +1300, Logan Shaw wrote: > > > > Added a new file documenting the adt7475 devicetree and added > > > > the > > > > four > > > > new properties to it. > > > > > > > > Signed-off-by: Logan Shaw <logan.shaw@xxxxxxxxxxxxxxxxxxx> > > > > --- > > > > + bypass-attenuator-in0: > > > > > > Needs a vendor prefix and a type ref. > > > > Adi (Analog Devices) sold the ADT product line (amongst other > > things) > > to On Semiconductor. As changing the vendor of these chips (in > > code) > > would break backwards compatibility should we keep the vendor as > > adi? > > Yes. It should match what's used in the compatible string(s). > > > To confirm, would this make the property "adi,adt7476,bypass- > > attenuator-in0"? > > > > So used in conjunction with patternProperties you would end up with > > something like: > > > > "adi,(adt7473|adt7475|adt7476|adt7490),bypass-attenuator-in[0134]" > > No for the part #'s. Just add 'adi,'. Maybe you thought for type ref > that's what I meant? A type ref is: > > $ref: /schemas/types.yaml#/definitions/uint32 Yes, I was a little confused but now I am on the right track.
