Hi, On Wed, Jan 22, 2020 at 4:46 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > Hi, > > On Fri, Dec 27, 2019 at 12:38 AM Taniya Das <tdas@xxxxxxxxxxxxxx> wrote: > > > > Add the display, video & graphics clock controller nodes supported on > > SC7180. > > > > Signed-off-by: Taniya Das <tdas@xxxxxxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > Can you add these to your patch? > > #include <dt-bindings/clock/qcom,dispcc-sc7180.h> > #include <dt-bindings/clock/qcom,gpucc-sc7180.h> > > ...otherwise the first user of each of the clocks will need to add the > #include and depending on what order patches landed things can get > weird. I think it's cleaner to assume that there will soon be a user > and proactively add the #includes. > > NOTE: at least one user of your patch can be found at > <https://lore.kernel.org/r/1579621928-18619-1-git-send-email-harigovi@xxxxxxxxxxxxxx>. > They don't add the #includes which means they don't compile atop your > patch. Breadcrumbs that I addressed my own feedback because I wanted to include Taniya's patch atop my series. See: https://lore.kernel.org/r/20200124144154.v2.10.I1a4b93fb005791e29a9dcf288fc8bd459a555a59@changeid -Doug
