Dne sobota, 25. januar 2020 ob 12:20:18 CET je Jernej Škrabec napisal(a): > Hi! > > Dne sobota, 25. januar 2020 ob 04:05:33 CET je Chen-Yu Tsai napisal(a): > > On Sat, Jan 25, 2020 at 7:20 AM Jernej Skrabec <jernej.skrabec@xxxxxxxx> > > wrote: > > > For some reason, A64 and H6 have swapped clocks and resets definitions. > > > H6 doesn't have rotation unit while A64 has. Swap around to correct the > > > issue. > > > > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxx> > > > > Could you add Fixes tags for this one? > > I'm not sure which commit to reference. H6 one? or also initial A64 one? > > I just found out that H5 compatible uses A64 structure, which is not > correct. H5 doesn't contain rotate core. > > Do you have any better idea how to nicely solve this mess? I'm thinking that > for v2 I would first decouple some compatibles, like this for H5 and R40 > and V3s from A83T (as it can be seen in the next patch). After that, rather > than switching definitions I would fix each compatible one by one. At the > end, if any entry is duplicated, I can add one commit to merge same > structures. This could also be a separate series of patches on which rotate driver series depends on. Best regards, Jernej
