On Thu, 23 Jan 2020, at 19:21, Andrew Peng wrote: > Update i2c aliases. > Change flash_memory mapping address and size. > Add in a gpio-keys section. > Add in a peci0 section. > Update i2c0,i2c0 and i2c11 section. > Enable vhub, vuart, spi1 and spi2. > Remove gpio from gpio section since it controlled by user space. These seem like largely independent items. I'd prefer that you have one commit for each item in the list, that way it's easier to review and understand the relationships between the bits of affected code. Basically, don't give people reasons to say no to your patches :) The smaller and more coherent the change, the easier it is to give it a Reviewed-by or Acked-by tag. Also commit messages should say _why_ you're making the changes not _what_ changes you're making. The diff tells us _what_, but nothing besides comments and the commit message can tell us why. It's much more convincing if you explain why your patch must be applied. Andrew
