Hi David.
> > +allOf:
> > + - $ref: panel/panel-common.yaml#
>
> not all of these properties are applicable.
>
> > +required:
> > + - compatible
> > + - reg
> > + - dc-gpios
> > + - reset-gpios
>
> Missing optional rotation and backlight properties.
Thanks for catching this. I have written a little .yaml files
since I applied this - and learned a little more of the syntax.
See attached patch for my attempt to fix this.
Please review.
Sam
>From 6b54fb0a071c0732cd4bd5b88f456b5a85bcf4f2 Mon Sep 17 00:00:00 2001
From: Sam Ravnborg <sam@xxxxxxxxxxxx>
Date: Mon, 20 Jan 2020 19:55:04 +0100
Subject: [PATCH] dt-bindings: restrict properties for sitronix,st7735r
David Lechner noticed (paraphrased):
- not all properties from panel-common are applicable.
- missing optional rotation and backlight properties
Fix this by listing all allowed properties, and do not allow other properties.
Fixes: abdd9e3705c8 ("dt-bindings: display: sitronix,st7735r: Convert to DT schema")
Reported-by: David Lechner <david@xxxxxxxxxxxxxx>
Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Cc: David Lechner <david@xxxxxxxxxxxxxx>
Cc: Rob Herring <robh@xxxxxxxxxx>
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
---
.../devicetree/bindings/display/sitronix,st7735r.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
index 8892d79e6e10..0cebaaefda03 100644
--- a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
+++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml
@@ -39,12 +39,19 @@ properties:
maxItems: 1
description: Display data/command selection (D/CX)
+ backlight: true
+ reg: true
+ reset-gpios: true
+ rotation: true
+
required:
- compatible
- reg
- dc-gpios
- reset-gpios
+additionalProperties: false
+
examples:
- |
#include <dt-bindings/gpio/gpio.h>
--
2.20.1
