Re: [PATCH] ARM: dts: imx7d: fix opp-supported-hw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 19.01.2020 12:09, Peng Fan wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
> 
> Per i.MX7D Document Number: IMX7DCEC Rev. 6, 03/2019,
> there are only consumer/industrial parts, and 1.2GHz
> is only support in consumer parts.
> 
> So exclude automotive from 792/996MHz/1.2GHz and exclude
> industrial from 1.2GHz.
> 
> Fixes: d7bfba7296ca ("ARM: dts: imx7d: Update cpufreq OPP table")
> Cc: Leonard Crestez <leonard.crestez@xxxxxxx> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>

My initial logic was that there is no particular reason to guard against 
parts which are not documented to exist so checking the speed grading 
should be sufficient.

With this patch if an imx7d chip with automotive qualification is 
released in the future (unlikely) then dtsi changes will be required 
before enabling cpufreq. This is not unreasonable.

Reviewed-by: Leonard Crestez <leonard.crestez@xxxxxxx>

> ---
>   arch/arm/boot/dts/imx7d.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 92f6d0c2a74f..4c22828df55f 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -44,7 +44,7 @@
>   			opp-hz = /bits/ 64 <792000000>;
>   			opp-microvolt = <1000000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0xd>, <0xf>;
> +			opp-supported-hw = <0xd>, <0x7>;
>   			opp-suspend;
>   		};
>   
> @@ -52,7 +52,7 @@
>   			opp-hz = /bits/ 64 <996000000>;
>   			opp-microvolt = <1100000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0xc>, <0xf>;
> +			opp-supported-hw = <0xc>, <0x7>;
>   			opp-suspend;
>   		};
>   
> @@ -60,7 +60,7 @@
>   			opp-hz = /bits/ 64 <1200000000>;
>   			opp-microvolt = <1225000>;
>   			clock-latency-ns = <150000>;
> -			opp-supported-hw = <0x8>, <0xf>;
> +			opp-supported-hw = <0x8>, <0x3>;
>   			opp-suspend;
>   		};
>   	};
> 





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux