On Mon, May 05, 2014 at 05:14:44PM +0200, Arnd Bergmann wrote: > On Friday 02 May 2014 18:43:01 Dave Martin wrote: > > On Fri, May 02, 2014 at 05:19:44PM +0200, Arnd Bergmann wrote: > > > On Friday 02 May 2014 15:23:29 Thierry Reding wrote: > > > > To some degree this also depends on how we want to handle IOMMUs. If > > > > they should remain transparently handled via dma_map_ops, then it makes > > > > sense to set this up at device instantiation time. But how can we handle > > > > this in situations where one device needs to master on two IOMMUs at the > > > > same time? Or if the device needs physically contiguous memory for > > > > purposes other than device I/O. Using dma_map_ops we can't control which > > > > allocations get mapped via the IOMMU and which don't. > > > > > > I still hope we can handle this in common code by selecting the right > > > dma_map_ops when the devices are instantiated, at least for 99% of the > > > cases. I'm not convinced we really need to handle the 'multiple IOMMUs > > > on one device' case in a generic way. If there are no common use cases > > > for that, we can probably get away with having multiple device nodes > > > and an ugly driver for the exception, instead of making life complicated > > > for everybody. > > > > Multiple IOMMUs certainly seems an unusual case for now. > > > > Being able to describe that in the DT doesn't necessarily mean the > > kernel has to support it: just as the kernel doesn't need to support > > all the features of a crazy hardware platform just someone was crazy > > enough to build it. > > Right. > > > My expectation was that we do some check when probing a device to figure > > out the path from the device to main memory, thus figuring out the dma > > mask, the IOMMU (if any) and any relevant device ID. This is a bit more > > complex than the existing situation, but I still think we could have > > common code for the bulk of it. > > I'd still prefer if we could keep following just "dma-ranges" to find > a path from device to memory, with an extension to handle IOMMUs etc, > but not describe the things to the extend that your proposal does. This is really a simplification. If we only had to consider the path from devices to memory, and if the pretence that the memory is at / works (almost always true, at least for general-purpose memory), then we often have a simpler problem. It is still not always solvable though, since a device could still have a unique access path with unique mappings that cannot be described in terms of any of the other paths. However, this is not just about DMA any more. Devices also master onto interrupt controllers to generate MSIs, onto IOMMUs to provide them with address space remapping, onto other devices via IOMMUs; and GPUs can master onto all kinds of things. The alternative to a completely generic description of bus mastering would be to consider the specific things that we are interested in allowing devices to master on, and describe the whole end-to-end link for each in the bus master's node. * memory * interrupt controllers (for MSIs) * IOMMUs This could lead to combinatorial blow-up as the number of target devices grows, since these linkages have to be re-described for every bus master -- especially for GPUs which could do a fair amount of device control by themselves. It could also lead to fragmentation as each binding solves common problems in different ways. The downside is that is any path flows through a dynamically configurable component, such as an IOMMU or a bridge that can be remapped, turned off etc., then unless we describe how the path is really linked together the kernel will need all sorts of baked-in knowledge in order to manage the system safely. The _effect_ of the problem component on the path is not static, so we can't describe that effect directly in the DT. For truly weird features that are unique to a particular platform that's OK, but "how devices are linked together" seems a much more general and useful concept than that. > We already pretend that things are a tree for the purposes of MMIO, > which is probably still close enough for the vast majority of cases. > For simplicity, I'd actually prefer keeping the illusion that MMIO > and DMA are two different things, which matches how operating systems > see things even if it's no longer true for the hardware. > > > If a device has different roles with completely different paths to > > memory, one option could be for the driver to instantiate two devices in > > the kernel. This puts the burden on the driver for the device, instead > > of the core framework. > > Yes, this is what I suggested earlier as well. I may have missed your point slightly before. Anyway, I think the "multiple master roles" issue is sufficiently unusual that describing them using multiple device nodes in the DT is reasonable. So I think I'm happy to get rid of the ability to specify and distinguish multiple roles within a single device node. Cheers ---Dave -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
