On 2020/1/18 0:32, Rob Herring wrote: > On Fri, 17 Jan 2020 08:21:40 +0800, Hanjie Lin wrote: >> The Amlogic A1 SoC Family embeds 1 USB Controllers: >> - a DWC3 IP configured as Host for USB2 and USB3 >> >> A glue connects the controllers to the USB2 PHY of A1 SoC. >> >> Signed-off-by: Yue Wang <yue.wang@xxxxxxxxxxx> >> Signed-off-by: Hanjie Lin <hanjie.lin@xxxxxxxxxxx> >> --- >> .../bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml | 38 ++++++++++++++++++++-- >> 1 file changed, 35 insertions(+), 3 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml: while parsing a block mapping > in "<unicode string>", line 107, column 7 > did not find expected key > in "<unicode string>", line 111, column 8 > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts' failed > make[1]: *** [Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.example.dts] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1224563 > Please check and re-submit. > > . > Hi Rob, Sorry, I missed a blank and didn't notice it. I will fix it in next version, and also pay more attentions to these problems later. Thanks, Hanjie