Hi Hanjie,
On Fri, Jan 17, 2020 at 1:22 AM Hanjie Lin <hanjie.lin@xxxxxxxxxxx> wrote:
>
> Enable USB2 PHY for Meson A1 SoC.
>
> Signed-off-by: Yue Wang <yue.wang@xxxxxxxxxxx>
> Signed-off-by: Hanjie Lin <hanjie.lin@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
personally I would squash this with patch 6/6 because it's only useful
together with patch 6/6
on the other hand: it's not worth sending a v7 just for this
> @@ -100,6 +101,18 @@
> #power-domain-cells = <1>;
> status = "okay";
> };
> +
> + usb2_phy1: phy@40000 {
> + status = "okay";
we typically use one of the following patterns:
- status = "disabled" in SoC.dts
- status = "okay" in board.dts whenever the peripheral should be used
(example: I2C, USB, ...)
OR
- no status property if the peripheral is mandatory on all boards (for
example: clock controller, ...)
so for consistency with other Amlogic .dts I would either drop the
status property or set it to disabled (and enable it in
meson-a1-ad401.dts)
same applies to patch 6/6
Martin
