On Fri, Jan 17, 2020 at 10:31:18AM -0800, Shiping Ji wrote: > This is to protect concurrent writes to the mci->error_desc as > suggested by James when reviewing the patch v3. Please comment that in the structure definition so that it is clear what it is for. > I'm trying to find a good scheme to make them shorter, at the moment > they are named according to the TRM. Yeah, keeping it the same as the documentation is also a good idea. I leave it up to you to decide as you'll be staring at that code when bugs happen. :) > I'm not sure how this can be done perfectly with tabs only :) Who says you should use only tabs? :-) > All other comments have been addressed in the next patch, many thanks! Thanks too. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette