On 1/17/20 3:15 AM, lijiazi wrote: > Introduce OF_DEVICE_NODE_FLAG_MAX for device node printk, if add > new device node flag, please add the corresponding flag abbreviation > to tbuf in device_node_string. > > Signed-off-by: lijiazi <lijiazi@xxxxxxxxxx> Hi lijiazi, A few small comments on this patch: > --- > Documentation/core-api/printk-formats.rst | 2 ++ > include/linux/of.h | 6 ++++++ > lib/vsprintf.c | 14 +++++++------- > 3 files changed, 15 insertions(+), 7 deletions(-) > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > index 8ebe46b1..c73ccad 100644 > --- a/Documentation/core-api/printk-formats.rst > +++ b/Documentation/core-api/printk-formats.rst > @@ -441,6 +441,8 @@ Examples:: > d - detached > P - Populated > B - Populated bus > + O - Overlay > + F - Overlay free cset Use tabs for indentation, like the preceding lines. > > Passed by reference. > > diff --git a/include/linux/of.h b/include/linux/of.h > index c669c0a..0453601 100644 > --- a/include/linux/of.h > +++ b/include/linux/of.h > @@ -147,6 +147,12 @@ extern raw_spinlock_t devtree_lock; > #define OF_OVERLAY 5 /* allocated for an overlay */ > #define OF_OVERLAY_FREE_CSET 6 /* in overlay cset being freed */ > > +/* Add flag max for %pOF related printk, if add new flag, please > + * increase following marco, and add abbreviations to tbuf in > + * device_node_string function. > + */ Incorrect multi-line comment style. > +#define OF_DEVICE_NODE_FLAG_MAX 6 /* maximum available flags */ > + > #define OF_BAD_ADDR ((u64)-1) > > #ifdef CONFIG_OF -- ~Randy
