On 09/05/2014 10:43, Hans de Goede wrote: > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > arch/arm/boot/dts/sun6i-a31-app4-evb1.dts | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/arch/arm/boot/dts/sun6i-a31-app4-evb1.dts b/arch/arm/boot/dts/sun6i-a31-app4-evb1.dts > index 270ab97..2bbf886 100644 > --- a/arch/arm/boot/dts/sun6i-a31-app4-evb1.dts > +++ b/arch/arm/boot/dts/sun6i-a31-app4-evb1.dts > @@ -13,6 +13,7 @@ > > /dts-v1/; > /include/ "sun6i-a31.dtsi" > +/include/ "sunxi-common-regulators.dtsi" > > / { > model = "Allwinner A31 APP4 EVB1 Evaluation Board"; > @@ -49,15 +50,8 @@ > }; > > reg_usb1_vbus: usb1-vbus { > - compatible = "regulator-fixed"; > - pinctrl-names = "default"; > pinctrl-0 = <&usb1_vbus_pin_a>; > - regulator-name = "usb1-vbus"; > - regulator-min-microvolt = <5000000>; > - regulator-max-microvolt = <5000000>; > - enable-active-high; > gpio = <&pio 7 27 0>; > status = "okay"; > }; I guess we could do the same for usb1_vbus_pin_a (keep the common definition and change the allwinner,pins property). Apart from that, Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> Best Regards, Boris > - > }; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html