> -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: 2020年1月17日 3:29 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx> > Cc: maz@xxxxxxxxxx; jason@xxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; > robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; > s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>; Andy > Duan <fugang.duan@xxxxxxx>; Joakim Zhang <qiangqing.zhang@xxxxxxx> > Subject: Re: [PATCH V5 1/2] dt-bindings/irq: add binding for NXP INTMUX > interrupt multiplexer > > On Wed, 15 Jan 2020 13:04:23 +0800, Joakim Zhang wrote: > > This patch adds the DT bindings for the NXP INTMUX interrupt > > multiplexer for i.MX8 family SoCs. > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > > --- > > .../interrupt-controller/fsl,intmux.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:2 > 1.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node > must be at root node > Error: > Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt > s:20.27-28 syntax error FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:300: recipe for target > 'Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.d > t.yaml' failed > make[1]: *** > [Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.d > t.yaml] Error 1 > Makefile:1263: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchw > ork.ozlabs.org%2Fpatch%2F1223172&data=02%7C01%7Cqiangqing.zhan > g%40nxp.com%7Caade42e256f248dc2ef708d79aba6941%7C686ea1d3bc2b4c6 > fa92cd99c5c301635%7C0%7C0%7C637147997726888265&sdata=7opsZO > V%2FKzIJBl4MoEESCYZa%2BjlzKKofG6m84SsfAHg%3D&reserved=0 > Please check and re-submit. Hi Rob, make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml CHKDT Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.yaml DTC Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt.yaml CHECK Documentation/devicetree/bindings/interrupt-controller/fsl,intmux.example.dt.yaml I don't know DTC also need pass the check, sorry for that. I will re-send the patch set. Best Regards, Joakim Zhang