Hi Geert. Thanks for doing the conversion to meta-schema. On Wed, Jan 15, 2020 at 01:45:44PM +0100, Geert Uytterhoeven wrote: > Convert the DT binding documentation for Sitronix ST7735R displays to DT > schema. > > Add a reference to the Adafruit 1.8" LCD while at it. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > new file mode 100644 > index 0000000000000000..21bccc91f74255e1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: GPL-2.0-only Use (GPL-2.0-only OR BSD-2-Clause) for new binding files. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/sitronix,st7735r.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sitronix ST7735R Display Panels Device Tree Bindings > + > +maintainers: > + - David Lechner <david@xxxxxxxxxxxxxx> > + > +description: > + This binding is for display panels using a Sitronix ST7735R controller in > + SPI mode. > + > +allOf: > + - $ref: panel/panel-common.yaml# I am no binding expert so I do not know how to add it. But the old binding described that this MUST be a child of spi. This is missing here. Other panels using spi does not have it - so it is probarly OK. So with the license fixed: Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - description: > + Adafruit 1.8" 160x128 Color TFT LCD (Product ID 358 or 618) > + items: > + - enum: > + - jianda,jd-t18003-t01 > + - const: sitronix,st7735r > + > + spi-max-frequency: > + maximum: 32000000 > + > + dc-gpios: > + maxItems: 1 > + description: Display data/command selection (D/CX) > + > +required: > + - compatible > + - reg > + - dc-gpios > + - reset-gpios > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + backlight: backlight { > + compatible = "gpio-backlight"; > + gpios = <&gpio 44 GPIO_ACTIVE_HIGH>; > + }; > + > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display@0{ > + compatible = "jianda,jd-t18003-t01", "sitronix,st7735r"; > + reg = <0>; > + spi-max-frequency = <32000000>; > + dc-gpios = <&gpio 43 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio 80 GPIO_ACTIVE_HIGH>; > + rotation = <270>; > + }; > + }; > + > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index ea8262509bdd21ac..3007f83bd504194a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5382,7 +5382,7 @@ M: David Lechner <david@xxxxxxxxxxxxxx> > T: git git://anongit.freedesktop.org/drm/drm-misc > S: Maintained > F: drivers/gpu/drm/tiny/st7735r.c > -F: Documentation/devicetree/bindings/display/sitronix,st7735r.txt > +F: Documentation/devicetree/bindings/display/sitronix,st7735r.yaml > > DRM DRIVER FOR SONY ACX424AKP PANELS > M: Linus Walleij <linus.walleij@xxxxxxxxxx> > -- > 2.17.1
