On 15/01/2020 14:22, Sam Ravnborg wrote: > Hi Jyri. > > On Wed, Jan 15, 2020 at 01:45:38PM +0200, Jyri Sarha wrote: >> This patch adds a new DRM driver for Texas Instruments DSS IPs used on >> Texas Instruments Keystone K2G, AM65x, and J721e SoCs. The new DSS IP is >> a major change to the older DSS IP versions, which are supported by >> the omapdrm driver. While on higher level the Keystone DSS resembles >> the older DSS versions, the registers are completely different and the >> internal pipelines differ a lot. >> >> DSS IP found on K2G is an "ultra-light" version, and has only a single >> plane and a single output. The K3 DSS IPs are found on AM65x and J721E >> SoCs. AM65x DSS has two video ports, one full video plane, and another >> "lite" plane without scaling support. J721E has 4 video ports, 2 video >> planes and 2 lite planes. AM65x DSS has also an integrated OLDI (LVDS) >> output. >> > ... >> v6: - Check CTM and gamma support from dispc_features when creating crtc >> - Implement CTM support for k2g and fix k3 CTM implementation >> - Remove gamma property persistence and always write color properties >> in a new modeset > > I applied this, just to throw this throgh my build setup. > > checkpatch reported: > total: 0 errors, 45 warnings, 46 checks, 4920 lines checked > > - space after cast > - CamelCase > - Macro argument > - length warnings > - alignment > > I would ignore the line length warnings for the coefficients, but fix the > rest. > You are using --subjective, or are there new warnings turned on since I rebased? Without it I only see long lines warnings and one "break is not useful after a goto or return" that I had accidentally added there. We have not cared too much of the long lines, but that is not a big deal, I'll fix them. I had checked the subjective warnings too, but there I used some consideration, if the warning would indicate a real problem. Should I get rid off all the subjective warnings (apart from the long lines in the coefficients)? Best regards, Jyri -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
