On Mon, Jan 13, 2020 at 7:25 PM Anson Huang <anson.huang@xxxxxxx> wrote: > > Hi, Rob > > > Subject: Re: [PATCH 1/3] dt-bindings: clock: Convert i.MX8MQ to json-schema > > > > On Fri, Jan 10, 2020 at 03:55:12PM +0800, Anson Huang wrote: > > > Convert the i.MX8MQ clock binding to DT schema format using > > > json-schema > > > > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > --- > > > .../devicetree/bindings/clock/imx8mq-clock.txt | 20 ------ > > > .../devicetree/bindings/clock/imx8mq-clock.yaml | 72 > > ++++++++++++++++++++++ > > > 2 files changed, 72 insertions(+), 20 deletions(-) delete mode > > > 100644 Documentation/devicetree/bindings/clock/imx8mq-clock.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/clock/imx8mq-clock.yaml > > > > Fails 'make dt_binding_check': > > > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names:0: 'ckil' was expected > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names:1: 'osc_25m' was expected > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names:2: 'osc_27m' was expected > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names:3: 'clk_ext1' was expected > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names:4: 'clk_ext2' was expected > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names:5: 'clk_ext3' was expected > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clock-names: ['osc_32k', 'osc_24m', 'clk_ext1', > > 'clk_ext2', 'clk_ext3', 'clk_ext4'] is too short > > /builds/robherring/linux-dt- > > review/Documentation/devicetree/bindings/clock/imx8mn- > > clock.example.dt.yaml: > > clock-controller@30380000: clocks: [[1], [2], [3], [4], [5], [6]] is too short > > I did NOT see build fail on my side, anything missed in my environment setup? The failure > log is for i.MX8MN, while this binding doc is i.MX8MQ, is it caused by the incorrect compatible > string which should be "fsl,imx8mq-ccm", but I made it "fsl,imx8mn-ccm" by mistake? Notice that the error is in imx8mn-clock.example.dt.yaml, not imx8mq-clock.example.dt.yaml. So you must have DT_SCHEMA_FILES set and yes it is due to the compatible being wrong. > > anson@anson-OptiPlex-790:~/workspace/stash/linux-next$ ./zeus.sh > *** Default configuration is based on 'defconfig' > # > # No change to .config > # > CHKDT Documentation/devicetree/bindings/clock/imx8mq-clock.yaml > SCHEMA Documentation/devicetree/bindings/processed-schema.yaml > DTC Documentation/devicetree/bindings/clock/imx8mq-clock.example.dt.yaml > CHECK Documentation/devicetree/bindings/clock/imx8mq-clock.example.dt.yaml
