On Fri, Jan 10, 2020 at 6:09 PM Matthias Brugger <matthias.bgg@xxxxxxxxx> wrote: > > > > On 08/01/2020 10:14, Nicolas Boichat wrote: > > On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@xxxxxxxxxxxx> wrote: > >> > >> minor nit, s/amr64/arm64/ in the commit title. > >> > >> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@xxxxxxxxxxxx> wrote: > >>> > >>> From: "yong.liang" <yong.liang@xxxxxxxxxxxx> > >>> > >>> 1. Include mt8183-reset.h and add reset-cells in infracfg > >>> in dtsi file > > > > Err, wait, doesn't this depend on > > http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html > > ? > > > > That's all a bit confusing, I thought we are fine to add the reset cells to > infracfg as we have the resets defined in > 64ebb57a3df6 ("clk: reset: Modify reset-controller driver") You're right, we're fine. But at least in theory, we should still have the binding documentation that I linked above. I will try to pick up all the required patches, split them across 8183/2712 and resend as one series. > That's why I took this part from: > https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@xxxxxxxxxxxx/ > > Please let me know if I'm wrong and I'll drop it. > > Regards, > Matthias > > >>> 2. Add watchdog device node > > > > Can we have a patch with just this change instead, since you're > > sending the binding with it. > > > >>> > >>> Signed-off-by: yong.liang <yong.liang@xxxxxxxxxxxx> > >> > >> Tested-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx> > >> > >>> --- > >>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++ > >>> 1 file changed, 8 insertions(+) > >>> [snip]