On 08.05.2014 17:59, Andreas Färber wrote:
> Hello,
>
> Am 05.05.2014 14:30, schrieb Vivek Gautam:
>> The exynos5250-snow has a SMSC USB3503 connected in
>> hardware only mode like a PHY. Enable support for it,
>> and add necessary 'reset-gpio' for it.
>>
>> This is in correspondance to similar patch by Mark Brown
>> 7c1b0ec ARM: dts: Enable USB hub on Arndale
>>
>> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>
>> ---
>>
>> Based on 'for-next' branch of kgene's linux-samsung tree.
>>
>> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
>> arch/arm/boot/dts/exynos5250-snow.dts | 14 ++++++++++++++
>> 2 files changed, 21 insertions(+)
>
> The same snippet as for snow also fixed my USB issues on spring.
> Should it go into exynos5250-cros-common.dtsi instead?
The GPIO pins used are different, so I don't think the hub node added by
these patches could be shared.
Also, I believe all you need to add is a simple node as follows
usb_hub {
compatible = "smsc,usb3503a";
reset-gpios = <&gpe1 0 1>;
};
at root level (see my comments to this patch in another reply), which is
affordable to be duplicated for every platform that requires it,
especially if the reset-gpios property differs between boards.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
