Hi Hsin-Yi, Thanks for sending this patch upstream, one comment below ... On 9/1/20 11:10, Hsin-Yi Wang wrote: > Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173 > SoC. > > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> > --- > .../devicetree/bindings/arm/mediatek.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 4043c5046441..a27b22f264a2 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -86,6 +86,24 @@ properties: > - const: mediatek,mt8135 > - items: > - enum: > + - google,elm > + - google,elm-rev1 > + - google,elm-rev2 > + - google,elm-rev3 > + - google,elm-rev4 > + - google,elm-rev5 > + - google,elm-rev6 > + - google,elm-rev7 > + - google,elm-rev8 Did you run dtbs_check [1] after having patch 2 applied? I think that will trigger some errors. I am not sure if this should be a const instead of an enum like we have in rockchip.yaml? [1] make ARCH=arm64 DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/mediatek.yaml dtbs_check Thanks, Enric > + - google,hana > + - google,hana-rev0 > + - google,hana-rev1 > + - google,hana-rev2 > + - google,hana-rev3 > + - google,hana-rev4 > + - google,hana-rev5 > + - google,hana-rev6 > + - google,hana-rev7 > - mediatek,mt8173-evb > - const: mediatek,mt8173 > - items: >
