On 08-01-20, 19:36, Saravana Kannan wrote: > On Wed, Jan 8, 2020 at 4:58 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote: > > > > On Wed, Jan 8, 2020 at 3:19 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > > > > > On 06-12-19, 16:24, Saravana Kannan wrote: > > > > The frequency OPP tables have helper functions to search for entries in the > > > > table based on frequency and get the frequency values for a given (or > > > > suspend) OPP entry. > > > > > > > > Add similar helper functions for bandwidth OPP tables to search for entries > > > > in the table based on peak bandwidth and to get the peak and average > > > > bandwidth for a given (or suspend) OPP entry. > > > > > > > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > > > --- > > > > drivers/opp/core.c | 301 +++++++++++++++++++++++++++++++++++------ > > > > include/linux/pm_opp.h | 43 ++++++ > > > > 2 files changed, 305 insertions(+), 39 deletions(-) > > > > > > > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > > > > index c79bbfac7289..3ff33a08198e 100644 > > > > --- a/drivers/opp/core.c > > > > +++ b/drivers/opp/core.c > > > > @@ -127,6 +127,29 @@ unsigned long dev_pm_opp_get_freq(struct dev_pm_opp *opp) > > > > } > > > > EXPORT_SYMBOL_GPL(dev_pm_opp_get_freq); > > > > > > > > +/** > > > > + * dev_pm_opp_get_bw() - Gets the bandwidth corresponding to an available opp > > > > + * @opp: opp for which peak bandwidth has to be returned for > > > > > > s/peak // > > > > Ack > > Actually, isn't this correct as is? peak bandwidth is "returned". > Average bandwidth is updated through the pointer. I think we return two values here, peak and avg bw. Just that we can't return two values from a routine, and so one is returned using a pointer. And so I though writing just bw may be better. -- viresh
